Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThorVG: Update to 0.14.0 #93655

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

capnm
Copy link
Contributor

@capnm capnm commented Jun 27, 2024

I have successfully tested the PR under 64-bit Linux.

Fixes #91781

@capnm capnm requested a review from a team as a code owner June 27, 2024 10:02
@akien-mga akien-mga added this to the 4.3 milestone Jun 27, 2024
@akien-mga
Copy link
Member

The current v0.14.0 tag upstream seems to be a pre-release. Maybe we should wait for the release to be tagged as latest, with in-depth release notes.

@capnm
Copy link
Contributor Author

capnm commented Jun 27, 2024

... and someone should check it on a 32-bit platform 😸

@capnm capnm mentioned this pull request Jun 27, 2024
53 tasks
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test. The update makes sense and looks good.

Checking:

pre-release upstream now.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release is fully published upstream now with the same commit.

Tested that it compiles fine with mingw for Windows x86_32.

I'm a bit wary of jumping on a new feature branch right as it's released, but upstream is quick to solve regressions so it's worth giving it a go and it should hopefully be stable enough by the time we release 4.3.

@capnm
Copy link
Contributor Author

capnm commented Jun 28, 2024

A remarkable synergy between two open-source projects in their bug hunting endeavors 🥇

@akien-mga akien-mga merged commit af9bca9 into godotengine:master Jun 28, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Godot crashes when importing a certain SVG icon with embedded PNG images
3 participants